----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review132896 -----------------------------------------------------------
src/tests/master_authorization_tests.cpp (line 1030) <https://reviews.apache.org/r/46784/#comment197180> Now this is not symmetrical to `SlaveAuthorizationTest`. src/master/http.cpp (line 861) <https://reviews.apache.org/r/46784/#comment197179> We should also update a help string saying that authz can be enabled. I'll take it in a separate patch. src/master/http.cpp (lines 872 - 881) <https://reviews.apache.org/r/46784/#comment197176> This snippet relies on the fact, that the endpoint being hit is from the "delegated" actor. See https://issues.apache.org/jira/browse/MESOS-5369 for details. We should mention the ticket here and rephrase the TODO. - Alexander Rukletsov On May 12, 2016, 9:25 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46784/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 9:25 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-5297 > https://issues.apache.org/jira/browse/MESOS-5297 > > > Repository: mesos > > > Description > ------- > > Access to the '/flags' endpoint is authorized using > the 'GET_ENDPOINT_WITH_PATH' action. > > > Diffs > ----- > > docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a > src/master/http.cpp a0d67671c89b9794e721dc3ba012acd3bdc447e3 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > > Diff: https://reviews.apache.org/r/46784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >