-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47162/#review132487
-----------------------------------------------------------




3rdparty/libprocess/src/tests/main.cpp (lines 45 - 63)
<https://reviews.apache.org/r/47162/#comment196706>

    Can we add little comments before these conditional compilation blocks?



3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 56)
<https://reviews.apache.org/r/47162/#comment196707>

    Can we use snake_case please?



3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 107)
<https://reviews.apache.org/r/47162/#comment197438>

    How about `close_fd`?
    Also, why can't we use `os::close` here? Do we even need the lambda then?



3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 115 - 116)
<https://reviews.apache.org/r/47162/#comment197439>

    Can you look through your review and remove the `std::`?



3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 212 - 216)
<https://reviews.apache.org/r/47162/#comment197437>

    We don't need the `std::`
    Do we need to mention map a second time?
    I think you can just initialize after the `=`.



3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 226 - 231)
<https://reviews.apache.org/r/47162/#comment197435>

    indentation.



3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 236)
<https://reviews.apache.org/r/47162/#comment197436>

    ASSERT_SOME if you're assuming that state in the next line.
    Here and elsewhere.



3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 730 - 731)
<https://reviews.apache.org/r/47162/#comment197433>

    Can we add a comment explaining why we're not running this on windows?


- Joris Van Remoortere


On May 12, 2016, 6:05 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47162/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 6:05 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3371
>     https://issues.apache.org/jira/browse/MESOS-3371
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: Made some of the tests work on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/main.cpp 
> c2ce9bc7830cd7bb0aa473f985106ec745207bf8 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/47162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to