> On May 13, 2016, 4:33 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp, line 107 > > <https://reviews.apache.org/r/47162/diff/1/?file=1377418#file1377418line107> > > > > How about `close_fd`? > > Also, why can't we use `os::close` here? Do we even need the lambda > > then?
I don't think you can get rid of the lambda, because the argument is `int*`, right? `os::close` takes an `int` as argument? I must be missing something here. Anyway we can make it more concise though. I vaguely recall a reason that we didn't just make a lambda that calls `os::close`, but I forget now what that was, so let's do it your way... - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47162/#review132487 ----------------------------------------------------------- On May 13, 2016, 6:18 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47162/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 6:18 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3371 > https://issues.apache.org/jira/browse/MESOS-3371 > > > Repository: mesos > > > Description > ------- > > Libprocess: Made some of the tests work on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/main.cpp > c2ce9bc7830cd7bb0aa473f985106ec745207bf8 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 727e940f12643974de4ff2734fba431b285b5de3 > > Diff: https://reviews.apache.org/r/47162/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
