----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47162/#review134484 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 65) <https://reviews.apache.org/r/47162/#comment199330> we can substitute some of these `.get().` with `->` 3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 85 - 86) <https://reviews.apache.org/r/47162/#comment199331> We can use this pattern: ``` Try<string> testdir = os::mkdtemp(); ASSERT_SOME(testdir); ``` 3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 115 - 121) <https://reviews.apache.org/r/47162/#comment199332> indentation. 3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 206 - 227) <https://reviews.apache.org/r/47162/#comment199333> indentation. 3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 213) <https://reviews.apache.org/r/47162/#comment199334> `snake_case` - Joris Van Remoortere On May 13, 2016, 6:18 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47162/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 6:18 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3371 > https://issues.apache.org/jira/browse/MESOS-3371 > > > Repository: mesos > > > Description > ------- > > Libprocess: Made some of the tests work on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/main.cpp > c2ce9bc7830cd7bb0aa473f985106ec745207bf8 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 727e940f12643974de4ff2734fba431b285b5de3 > > Diff: https://reviews.apache.org/r/47162/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
