----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review133198 -----------------------------------------------------------
This looks good but when you mentioned the consecutive failures in the description I was confused. The test should probably just say that we launch a task that toggles between healthy and unhealthy, and will never be killed because no consecutive health failures occur. That will make it clear that we need to ignore subsequent status updates because we'll continue to receive healthy/unhealthy updates. Could you update the description to clarify this? src/tests/health_check_tests.cpp (line 504) <https://reviews.apache.org/r/46307/#comment197483> Why did this change? - Benjamin Mahler On May 7, 2016, 8:59 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46307/ > ----------------------------------------------------------- > > (Updated May 7, 2016, 8:59 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > Neil Conway, and Timothy Chen. > > > Bugs: MESOS-1802 > https://issues.apache.org/jira/browse/MESOS-1802 > > > Repository: mesos > > > Description > ------- > > We need to ignore subsequent status updates in HealthStatusChange > tests. In our test cases, we set `consecutive_failures` to 3 in > HealthCheck message definition. But the counter for > `consecutiveFailures` in `mesos-health-check` would be reset to 0 > after a success check. It is possible to continue to receive status > updates before we stop the driver. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb > > Diff: https://reviews.apache.org/r/46307/diff/ > > > Testing > ------- > > # I still could not reproduce the problem in old code after repeatedly tests. > So seems no way to verify whether my assumption is correct or not. > > > Thanks, > > haosdent huang > >
