> On May 13, 2016, 8:50 p.m., Benjamin Mahler wrote: > > This looks good but when you mentioned the consecutive failures in the > > description I was confused. The test should probably just say that we > > launch a task that toggles between healthy and unhealthy, and will never be > > killed because no consecutive health failures occur. That will make it > > clear that we need to ignore subsequent status updates because we'll > > continue to receive healthy/unhealthy updates. > > > > Could you update the description to clarify this?
Thank you for your clarify, just updated. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review133198 ----------------------------------------------------------- On May 17, 2016, 4:46 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46307/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 4:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > Neil Conway, and Timothy Chen. > > > Bugs: MESOS-1802 > https://issues.apache.org/jira/browse/MESOS-1802 > > > Repository: mesos > > > Description > ------- > > In HealthStatusChange test cases, we launch a task that toggles between > healthy and unhealthy, and will never be killed because no consecutive > health failures occur. We need to ignore subsequent status updates it > is possible to continue to receive status updates before we stop the > driver. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb > > Diff: https://reviews.apache.org/r/46307/diff/ > > > Testing > ------- > > # I still could not reproduce the problem in old code after repeatedly tests. > So seems no way to verify whether my assumption is correct or not. > > > Thanks, > > haosdent huang > >
