-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47374/#review133438
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47374]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 16, 2016, 8:02 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47374/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 8:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Kapil Arya, and Jan 
> Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives external projects easier access to the test helpers used in
> mesos tests.  
> 
> For example, a module writer may want to write a test like 
> `src/tests/oversubscription_tests.cpp`.  To build and link against 
> this library, the module writer would mimic the build flags for tests:
> ```
> my_module_CPPFLAGS =                   \
>   -I$(ZOOKEEPER)/include               \
>   -I$(ZOOKEEPER)/generated             \
>   -DSOURCE_DIR=\"$(abs_top_srcdir)\"   \
>   -DBUILD_DIR=\"$(abs_top_builddir)\"  \
>   ...
> ```
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
> 
> Diff: https://reviews.apache.org/r/47374/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to