This is an automatically generated e-mail. To reply, visit:

(Updated May 17, 2016, 8:36 p.m.)

Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched 
to 'mcypark'.

Bugs: MESOS-5398

Repository: mesos

Description (updated)

The previous read() implementation was based on calling getline() to
read in chunks of data from a file. This is fine for text-based files,
but is a little strange for binary files.

The new implementation reads in chunks of raw bytes into a stack
allocated buffer before copying them into their final location. I
usually don't like stack allocated buffers because of their potential
security implications when it comes to stack buffer overflows, but I
took extra care here to make sure there won't be any.

Diffs (updated)


Diff: https://reviews.apache.org/r/47481/diff/


make check -j


Kevin Klues

Reply via email to