-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47481/
-----------------------------------------------------------
(Updated May 18, 2016, 3:25 a.m.)
Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched
to 'mcypark'.
Changes
-------
Removed erroneous #include
Bugs: MESOS-5398
https://issues.apache.org/jira/browse/MESOS-5398
Repository: mesos
Description
-------
The previous read() implementation was based on calling getline() to
read in chunks of data from a file. This is fine for text-based files,
but is a little strange for binary files.
The new implementation reads in chunks of raw bytes into a stack
allocated buffer before copying them into their final location. I
usually don't like stack allocated buffers because of their potential
security implications when it comes to stack buffer overflows, but I
took extra care here to make sure there won't be any.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/read.hpp
e1e97c1bcb7493a734fc77721a83c230b1a23724
Diff: https://reviews.apache.org/r/47481/diff/
Testing
-------
make check -j
Thanks,
Kevin Klues
