----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47481/#review133834 -----------------------------------------------------------
Ship it! 3rdparty/stout/include/stout/os/read.hpp (line 108) <https://reviews.apache.org/r/47481/#comment198483> Not yours, but we should avoid including caller-available information here as it leads to redundant information when error messages are composed. 3rdparty/stout/include/stout/os/read.hpp (line 120) <https://reviews.apache.org/r/47481/#comment198480> true instead of 1? 3rdparty/stout/include/stout/os/read.hpp (line 124) <https://reviews.apache.org/r/47481/#comment198481> Perhaps we should mention that ferror does not modify errno if the file is valid. 3rdparty/stout/include/stout/os/read.hpp (line 137) <https://reviews.apache.org/r/47481/#comment198482> Perhaps we should assert feof here? - Benjamin Mahler On May 18, 2016, 3:25 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47481/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 3:25 a.m.) > > > Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and switched > to 'mcypark'. > > > Bugs: MESOS-5398 > https://issues.apache.org/jira/browse/MESOS-5398 > > > Repository: mesos > > > Description > ------- > > The previous read() implementation was based on calling getline() to > read in chunks of data from a file. This is fine for text-based files, > but is a little strange for binary files. > > The new implementation reads in chunks of raw bytes into a stack > allocated buffer before copying them into their final location. I > usually don't like stack allocated buffers because of their potential > security implications when it comes to stack buffer overflows, but I > took extra care here to make sure there won't be any. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/read.hpp > e1e97c1bcb7493a734fc77721a83c230b1a23724 > > Diff: https://reviews.apache.org/r/47481/diff/ > > > Testing > ------- > > make check -j > > > Thanks, > > Kevin Klues > >
