-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review132116
-----------------------------------------------------------




src/authorizer/local/authorizer.cpp (line 216)
<https://reviews.apache.org/r/46613/#comment196241>

    Please update to use `foreach`. I've updated the other instances.



src/authorizer/local/authorizer.cpp (line 229)
<https://reviews.apache.org/r/46613/#comment196242>

    Please update to use `foreach`. I've updated the other instances.


- Michael Park


On May 18, 2016, 10:16 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46613/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 10:16 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Bugs: MESOS-5169
>     https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to allow for framework and task level filtering we introduce
> the following authorizer actions:
> * FILTER_FRAMEWORK_WITH_INFO
> * FILTER_TASK_WITH_EXECUTOR_INFO = 13;
> * FILTER_TASK_WITH_COMMAND_INFO = 14;
> * FILTER_TASK_WITH_TASK = 15;
> 
> Note that we need different actions for authorizing a tasks
> based on the object being authorized.
> 
> We also introduce the following acls for the local authorizer:
> * ViewFrameworks  (giving access to frameworks running  
>    under a specific OS user
> * ViewTasks view_tasks (giving access to Tasks run under a
>     specific OS user)
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   include/mesos/authorizer/acls.proto 
> 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
>   include/mesos/authorizer/authorizer.proto 
> 32492a59ad95df3bb673ec42321518f86c11af59 
>   src/authorizer/local/authorizer.cpp 
> aa1a9d8e5c7fb86b6310015d93aeacb466a307ef 
> 
> Diff: https://reviews.apache.org/r/46613/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to