----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review130558 -----------------------------------------------------------
This is still a work in progress, I assume. Do we need to modify the authorizer interface to be able to take a Shared<TaskInfo> before we can add these new actions? docs/authorization.md (lines 37 - 38) <https://reviews.apache.org/r/46613/#comment194381> Numbers should keep incrementing include/mesos/authorizer/acls.proto (line 152) <https://reviews.apache.org/r/46613/#comment194382> Not necessarily an operator include/mesos/authorizer/authorizer.proto (line 62) <https://reviews.apache.org/r/46613/#comment194383> s/TASK/EXECUTOR/? src/master/http.cpp (line 1604) <https://reviews.apache.org/r/46613/#comment194384> These are not actually called anywhere yet, correct? src/master/http.cpp (line 1615) <https://reviews.apache.org/r/46613/#comment194387> This line isn't correct. We'd rather be passing the entire TaskInfo for WITH_INFO, not some undefined field as a string value. - Adam B On April 24, 2016, 11:19 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46613/ > ----------------------------------------------------------- > > (Updated April 24, 2016, 11:19 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-5169 > https://issues.apache.org/jira/browse/MESOS-5169 > > > Repository: mesos > > > Description > ------- > > Introduced VIEW_(FRAMEWORK,TASK}_WITH_INFO actions to authorizer. > > > Diffs > ----- > > docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 > include/mesos/authorizer/acls.proto > c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 > include/mesos/authorizer/authorizer.proto > 40d93ea257d1df8d22eee8a21667db90d579a8fe > src/authorizer/local/authorizer.cpp > c744a16041c2466d3839a37fbee2bf86887bf4e1 > src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 > > Diff: https://reviews.apache.org/r/46613/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Joerg Schad > >
