----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review134771 -----------------------------------------------------------
include/mesos/authorizer/authorizer.proto (line 42) <https://reviews.apache.org/r/46613/#comment199678> `s/task_info=/task_info =/` include/mesos/authorizer/authorizer.proto (line 79) <https://reviews.apache.org/r/46613/#comment199676> `s/VIEW_EXECUTORS/VIEW_EXECUTOR/` `s/ExcecutorInfo/ExecutorInfo/` Both instances of `a` should be `an`. include/mesos/authorizer/authorizer.proto (line 80) <https://reviews.apache.org/r/46613/#comment199677> `s/informationis/information is/` src/authorizer/local/authorizer.cpp (line 396) <https://reviews.apache.org/r/46613/#comment199681> Shift this 2 spaces to the left - Michael Park On May 24, 2016, 9:44 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46613/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 9:44 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Michael Park. > > > Bugs: MESOS-5169 > https://issues.apache.org/jira/browse/MESOS-5169 > > > Repository: mesos > > > Description > ------- > > In order to allow for framework and task level filtering we introduce > the following authorizer actions: > * VIEW_FRAMEWORK > * VIEW_TASK > * VIEW_EXECUTOR > > Note that we need different actions for authorizing a tasks > based on the object being authorized. > > We also introduce the following acls for the local authorizer: > * ViewFrameworks (giving access to frameworks running under > a specific OS user) > * ViewTasks view_tasks (giving access to Tasks run under a > specific OS user) > * ViewExecutors view_executors (giving access to Executors run > under a specific OS user) > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > b178f53a299a2941afc073af963f6aff26af1ca8 > include/mesos/authorizer/authorizer.proto > 911a2271211249a41c4467f6754e9996f640bf38 > src/authorizer/local/authorizer.cpp > dc53bc4374aea98b5ed41ade5617374d2447229b > > Diff: https://reviews.apache.org/r/46613/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Joerg Schad > >