-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134279
-----------------------------------------------------------




site/README.md (line 15)
<https://reviews.apache.org/r/47695/#comment199024>

    I think `make` is enough here?



site/README.md (line 36)
<https://reviews.apache.org/r/47695/#comment199025>

    s/Git/git/



site/README.md (lines 63 - 68)
<https://reviews.apache.org/r/47695/#comment199026>

    The old version of the text here is fine. No need to update it.



site/Rakefile (line 5)
<https://reviews.apache.org/r/47695/#comment199028>

    shouldn't the "build" task happen after "doxygen" and "javadoc"?



site/Rakefile (lines 75 - 82)
<https://reviews.apache.org/r/47695/#comment199029>

    why the change from "pubish" to "source" here?



site/build.sh (lines 28 - 30)
<https://reviews.apache.org/r/47695/#comment199027>

    bundle install && rake && rake dev


- Vinod Kone


On May 22, 2016, 10:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
>     https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> 
> 
> Diffs
> -----
> 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Dockerfile PRE-CREATION 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> -------
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to