> On May 22, 2016, 5:46 p.m., Vinod Kone wrote: > > site/Rakefile, line 5 > > <https://reviews.apache.org/r/47695/diff/1/?file=1390761#file1390761line5> > > > > shouldn't the "build" task happen after "doxygen" and "javadoc"?
According my test, there are not differences not matter we put it before `:build` or after `:build`. I put it after `:build` because I saw ``` The doxygen and javadoc pages must be generated after running rake. ``` in https://github.com/apache/mesos/tree/master/site But let me move it before `:build` because not differences. > On May 22, 2016, 5:46 p.m., Vinod Kone wrote: > > site/Rakefile, lines 75-82 > > <https://reviews.apache.org/r/47695/diff/1/?file=1390761#file1390761line75> > > > > why the change from "pubish" to "source" here? haha, there is a long story here. At first, I use `publish` folder when generate `javadoc` and `doxygen`. However, `middleman server` only serve files under `sources`(`middlman server` would generate a sitemap structure internal and route requests by it). If we want to make it serve files for our custom folder under `publish`, we need to upgrade `middleman` from 3 to 4 and use `import_path` config item. After I upgrade `middleman` to 4, I find the site broken and try to fix them and make it work under `middleman` 4 . Eventually, I neary change almost files under `site` folder... At that time, I think the better way is just put then under `source` folder when generate `javadoc` and `doxygen`. We still could keep it use `publish` here, and it should be shown after we public it to the apache website. However, we could not preview `javadoc` and `doxygen` locally when using `middleman server`. So I perfer to use `source` folder here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134279 ----------------------------------------------------------- On May 23, 2016, 5:49 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47695/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 5:49 p.m.) > > > Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and > Vinod Kone. > > > Bugs: MESOS-5431 > https://issues.apache.org/jira/browse/MESOS-5431 > > > Repository: mesos > > > Description > ------- > > In this changes, we include below items to make it more convenience to > develop and generate the website. > > * added `doxygen` and `javadoc` to `rake` default target. > * added `build.sh` as the wrapper for the website generation to make > sure we clean up generated documents when exit. > * switched the `Dockerfile` to based on `centos:7` because the default > `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js` > correctly when generate `doxygen` documents. > * adjusted the `Dockerfile` and `README.md` locations to avoid we > distract at finding the website generation document. > * updated `release-guide.md` with the new website generation and > development workflows. > > > Diffs > ----- > > docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 > site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 > site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 > site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a > site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e > site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e > site/build.sh PRE-CREATION > support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 > support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 > > Diff: https://reviews.apache.org/r/47695/diff/ > > > Testing > ------- > > Tested in OS X and Ubuntu 14.04 > > For document changes, could verified from > https://github.com/haosdent/mesos/tree/MESOS-5431/site > > To verify website works fine after this changes, could check it via this gif: > > ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif) > > > Thanks, > > haosdent huang > >