> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > include/mesos/authorizer/authorizer.hpp, line 54
> > <https://reviews.apache.org/r/47558/diff/6/?file=1390615#file1390615line54>
> >
> >     If we go with `ObjectAuthorizer`, we should call this `authorized`, but 
> > at the least we should call it `allow` if we were to keep `ObjectAllower`.

ok, see above.


> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > include/mesos/authorizer/authorizer.hpp, line 137
> > <https://reviews.apache.org/r/47558/diff/6/?file=1390615#file1390615line137>
> >
> >     I think we should call this `authorized`.

Why do you want to call authorized as well? This for getting an Allower which 
in turn can authorize/allow stuff...


> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > src/authorizer/local/authorizer.cpp, line 59
> > <https://reviews.apache.org/r/47558/diff/6/?file=1390617#file1390617line59>
> >
> >     Is this WIP? Are we actually planning to only handle `VIEW_FRAMEWORKS`?

No, i just split it up in several reviews. See 
https://reviews.apache.org/r/47703/


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134295
-----------------------------------------------------------


On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-5403
>     https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allower interface to authorizer.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp 
> ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 
> 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> -------
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to