----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review134772 -----------------------------------------------------------
include/mesos/authorizer/authorizer.hpp (line 43) <https://reviews.apache.org/r/47558/#comment199682> ```c++ struct Object { ``` include/mesos/authorizer/authorizer.hpp (lines 46 - 47) <https://reviews.apache.org/r/47558/#comment199679> We should keep `Task` and `TaskInfo` declared in the same order between this and https://reviews.apache.org/r/46613. include/mesos/authorizer/authorizer.hpp (line 58) <https://reviews.apache.org/r/47558/#comment199687> `virtual ~ObjectAllower() = default;` include/mesos/authorizer/authorizer.hpp (line 140) <https://reviews.apache.org/r/47558/#comment199683> `s/& subject/& subject/` - Michael Park On May 25, 2016, 5:19 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47558/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 5:19 a.m.) > > > Review request for mesos, Adam B and Michael Park. > > > Bugs: MESOS-5403 > https://issues.apache.org/jira/browse/MESOS-5403 > > > Repository: mesos > > > Description > ------- > > Added ObjectAllower interface to authorizer. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > ed5f9e73661e25a83722cf1e408ae61023cd4a21 > src/authorizer/local/authorizer.hpp > 61388454025211fd7d53e71a86983fd8479950b6 > src/authorizer/local/authorizer.cpp > dc53bc4374aea98b5ed41ade5617374d2447229b > src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 > src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e > > Diff: https://reviews.apache.org/r/47558/diff/ > > > Testing > ------- > > tested entire chain. > > > Thanks, > > Joerg Schad > >
