-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47608/#review134390
-----------------------------------------------------------




src/tests/slave_tests.cpp (line 3265)
<https://reviews.apache.org/r/47608/#comment199175>

    If this is a WIP, I would recommend to limit the reviewers list. Its 
currently `mesos` group.
    
    If this review is intended for `mesos` group, I would recommend taking out 
debug statements like these. 
    
    I would also recommend to use meaningful variable names (unlike L3318). 
(L3318 in particular, does not need the extra variable. See other similar code.)


- Jojy Varghese


On May 20, 2016, 6:38 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47608/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP: Add Labels from TaskInfo into TaskStatus message.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp ce0e7b1f1d17c3b82d835b0a6296ed7b1e9eeac1 
>   src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 
>   src/tests/slave_tests.cpp e1f5bfe074c357f46403887365b3f9ae554000b4 
> 
> Diff: https://reviews.apache.org/r/47608/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Reply via email to