----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review135198 -----------------------------------------------------------
Srini, please add MESOS-4135 to `Bugs` filed at right-top of the page. src/slave/slave.cpp (line 3454) <https://reviews.apache.org/r/47608/#comment200237> The `Executor::updateTaskState` now only update status for `launchedTasks`, why do you want to update `labels` for `termiantedTasks`? What is the use of `labeles` for `termiantedTasks`? src/slave/slave.cpp (line 3455) <https://reviews.apache.org/r/47608/#comment200234> I think you can update `Executor::updateTaskState` directly https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L6132-L6144 - Guangya Liu On 五月 20, 2016, 6:38 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47608/ > ----------------------------------------------------------- > > (Updated 五月 20, 2016, 6:38 p.m.) > > > Review request for mesos, Gilbert Song and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > WIP: Add Labels from TaskInfo into TaskStatus message. > > > Diffs > ----- > > src/slave/slave.cpp ce0e7b1f1d17c3b82d835b0a6296ed7b1e9eeac1 > src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 > src/tests/slave_tests.cpp e1f5bfe074c357f46403887365b3f9ae554000b4 > > Diff: https://reviews.apache.org/r/47608/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
