> On 五月 25, 2016, 4:41 p.m., Shuai Lin wrote: > > src/slave/slave.cpp, line 3454 > > <https://reviews.apache.org/r/47608/diff/1/?file=1388247#file1388247line3454> > > > > Should we also search in in `termiantedTasks`? > > > > ```cpp > > // Terminated but pending updates. > > LinkedHashMap<TaskID, Task*> terminatedTasks; > > ```
The Executor::updateTaskState now only update status for launchedTasks, why do you want to update labels for termiantedTasks? What is the use of labeles for termiantedTasks? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134782 ----------------------------------------------------------- On 五月 20, 2016, 6:38 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47608/ > ----------------------------------------------------------- > > (Updated 五月 20, 2016, 6:38 p.m.) > > > Review request for mesos, Gilbert Song and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > WIP: Add Labels from TaskInfo into TaskStatus message. > > > Diffs > ----- > > src/slave/slave.cpp ce0e7b1f1d17c3b82d835b0a6296ed7b1e9eeac1 > src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 > src/tests/slave_tests.cpp e1f5bfe074c357f46403887365b3f9ae554000b4 > > Diff: https://reviews.apache.org/r/47608/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
