----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48375/ -----------------------------------------------------------
(Updated June 11, 2016, 3:05 a.m.) Review request for mesos and Benjamin Mahler. Changes ------- Rebased for https://reviews.apache.org/r/48578 Bugs: MESOS-5563 https://issues.apache.org/jira/browse/MESOS-5563 Repository: mesos Description ------- Previously, components outside of `src/slave/containerizers/mesos/isolators/gpu` had to protect their \#includes for certain Nvidia header files with the ENABLE_NVIDIA_GPU_SUPPORT flag. Other headers strictly *could not* be wrapped in this flag. This commit cleans up this header madness, by creating a common "nvidia.hpp" header that takes care of all the dependencies. All componenents outside of `src/slave/containerizers/mesos/isolators/gpu` now only need to \#include this one header instead of managing everything themselves. Diffs (updated) ----- src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 src/slave/containerizer/containerizer.cpp faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2 src/slave/containerizer/docker.hpp 311dca23ac17fb533866aba1de2b81d750bbe6df src/slave/containerizer/mesos/containerizer.hpp a1a00020668f6da8d611f26e5637afffc87d09ba src/slave/containerizer/mesos/containerizer.cpp 92c9898fb41ca0ffbda05e53b595b05c96f4f596 src/slave/containerizer/mesos/isolators/gpu/components.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/gpu/isolator.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7 src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 65ffbafffeb5dac372b5770d2a1560a942a822e2 Diff: https://reviews.apache.org/r/48375/diff/ Testing ------- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues
