-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48375/
-----------------------------------------------------------
(Updated June 29, 2016, 11:50 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Rebased
Bugs: MESOS-5563
https://issues.apache.org/jira/browse/MESOS-5563
Repository: mesos
Description
-------
Previously, any components outside of
`src/slave/containerizers/mesos/isolators/gpu` that needed access to
header files in this folder had to protect (most) of their #includes
with an #ifdef __linux__ directive. However, at least one header file
should not be protected by this directive (i.e. components.hpp),
making it confusing as to which headers should be protected by
__linux__ and which ones shouldn't. Before this commit, components
could end up with #include blocks such as:
#ifdef __linux__
#include "src/slave/containerizers/mesos/isolators/gpu/allocator.hpp"
#include "src/slave/containerizers/mesos/isolators/gpu/nvidia.hpp"
#include "src/slave/containerizers/mesos/isolators/gpu/nvml.hpp"
#endif
#include "src/slave/containerizers/mesos/isolators/gpu/components.hpp"
This commit cleans up this header madness, by creating a common
"nvidia.hpp" header that takes care of all the dependencies on
__linux__ for you. All componenents outside of
`src/slave/containerizers/mesos/isolators/gpu` now only need to #include
this one header instead of managing everything themselves.
Diffs (updated)
-----
src/Makefile.am bdad9c2ae07585b53aac97341550f3ea0b852ae7
src/slave/containerizer/containerizer.cpp
f2ff116f938c22c8698ee66046e549229d66d277
src/slave/containerizer/docker.hpp 51880a50a45fc89e84c597d831c74010663c440e
src/slave/containerizer/mesos/containerizer.hpp
8e347735fad2301a2bcbc7d141efbf0f2b708435
src/slave/containerizer/mesos/containerizer.cpp
63cf92217054fab43c843379c86e25ce7f07c7d9
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp
a6734105dcb3efadfceb7cdd357b749813a5bf40
src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp
88dd9b20ab75355f4f0ac9628f654db05a783a8e
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
28ec3f9954576d78153e9d0f57e22a240e950639
Diff: https://reviews.apache.org/r/48375/diff/
Testing
-------
GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
Thanks,
Kevin Klues
