----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136633 -----------------------------------------------------------
(1) This could benefit from a unit test. (2) More importantly, what happens if the directory already exists and contains data? By "cleanup", you mean delete any existing data in the directory, right? ISTM this could very easily result in deleting user data, if I have an existing data set that I want to make accessible to a Mesos task. - Neil Conway On June 7, 2016, 5:53 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48315/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 5:53 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5448 > https://issues.apache.org/jira/browse/MESOS-5448 > > > Repository: mesos > > > Description > ------- > > Root of a MOUNT disk is not deleted on volume DELETE. When we do a > CREATE on a persistent volume and the root directory exists (which > can happen for MOUNT disks), we allow the operation only if the > contents within the root directory is empty. If not, we do not update > the checkpoint with this volume and exit, so as to cleanup when the > slave restarts and handles the CheckpointResourcesMessage. > > > Diffs > ----- > > src/slave/slave.cpp 03a845ebdbb057051ced2d6b7a0d3e5aafd5ac55 > > Diff: https://reviews.apache.org/r/48315/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
