----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136785 -----------------------------------------------------------
src/slave/slave.cpp (line 2541) <https://reviews.apache.org/r/48315/#comment201875> I think this would be a bit cleaner written: ``` if (result.isError()) { isFailed = true; additionalError = result.error(); } else if (result.get() == false) { isFailed = true; additionalError = "Directory not empty..."; } ``` src/slave/slave.cpp (line 2546) <https://reviews.apache.org/r/48315/#comment201874> Whitespace. - Neil Conway On June 9, 2016, 12:25 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48315/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 12:25 a.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-5448 > https://issues.apache.org/jira/browse/MESOS-5448 > > > Repository: mesos > > > Description > ------- > > Root of a MOUNT disk is not deleted on volume DELETE. When we do a > CREATE on a persistent volume and the root directory exists (which > can happen for MOUNT disks), we allow the operation only if the > contents within the root directory is empty. If not, we do not update > the checkpoint with this volume and exit, so as to cleanup when the > slave restarts and handles the CheckpointResourcesMessage. > > > Diffs > ----- > > src/slave/slave.cpp d635dd2c6f6fce5a9eeefc5dcdf84e00cdc833b6 > > Diff: https://reviews.apache.org/r/48315/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
