> On June 14, 2016, 8:45 a.m., Neil Conway wrote: > > src/slave/slave.cpp, line 2540 > > <https://reviews.apache.org/r/48315/diff/3/?file=1417269#file1417269line2540> > > > > I think this justifies a unit test. What do you think?
Added checks in unit test to verify that contents of directory is empty. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review137467 ----------------------------------------------------------- On June 15, 2016, 11:01 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48315/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 11:01 p.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-5448 > https://issues.apache.org/jira/browse/MESOS-5448 > > > Repository: mesos > > > Description > ------- > > Root of a MOUNT disk is not deleted on volume DELETE. When we do a > CREATE on a persistent volume and the root directory exists (which > can happen for MOUNT disks), we allow the operation only if the > contents within the root directory is empty. If not, we do not update > the checkpoint with this volume and exit, so as to cleanup when the > slave restarts and handles the CheckpointResourcesMessage. > > > Diffs > ----- > > docs/multiple-disk.md 20b99e0e57360ad43804201b27e593d7ed48ce2c > src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 > src/tests/persistent_volume_tests.cpp > 5125a8da44759d1235fddac26e9eb5436c3d037b > > Diff: https://reviews.apache.org/r/48315/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
