----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/#review136878 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 397) <https://reviews.apache.org/r/47664/#comment201980> This can be in any of the following form: https://github.com/docker/docker/blob/master/image/spec/v1.md#container-runconfig-field-descriptions Are we going to support all of them? I guess we need to introduce a protobuf type for encapsulating the user and group info. You should take a look at OCI and Appc spec too: https://github.com/opencontainers/runtime-spec/blob/master/config.md#user https://github.com/appc/spec/blob/master/spec/aci.md Maybe for now, we can add 'user' and 'group' in ContainerLaunchInfo, and document that they can either be numerical or non numerical. There are different meanings. Also, add a TODO there, we probably need to handle suplementary groups as well in the future. - Jie Yu On May 26, 2016, 8:55 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47664/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 8:55 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Implemented image user support in docker runtime isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.hpp > 272636fcf12c865b31a11364f23d7aee9c6225db > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > eb2790d44ee08c81d31fbe28e7a8ffe88edba870 > > Diff: https://reviews.apache.org/r/47664/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
