----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47664/#review137776 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/docker/runtime.hpp (line 58) <https://reviews.apache.org/r/47664/#comment202964> s/Image/Container/ I would prefer `ContainerUser` src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 103) <https://reviews.apache.org/r/47664/#comment202965> please use 'container user' consistently - Jie Yu On June 15, 2016, 5:46 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47664/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 5:46 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Bugs: MESOS-4757 > https://issues.apache.org/jira/browse/MESOS-4757 > > > Repository: mesos > > > Description > ------- > > Implemented image user support in docker runtime isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.hpp > 272636fcf12c865b31a11364f23d7aee9c6225db > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > eb2790d44ee08c81d31fbe28e7a8ffe88edba870 > > Diff: https://reviews.apache.org/r/47664/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
