> On May 26, 2016, 3:52 p.m., Kapil Arya wrote:
> > src/slave/main.cpp, lines 239-288
> > <https://reviews.apache.org/r/47892/diff/1/?file=1395393#file1395393line239>
> >
> >     While we are discussing/fixing the ordering issues, can we reach a 
> > consensus on this particular ordering as well? As in, why do we have the 
> > following order:
> >     
> >         modules/hooks -> VersionProcess -> build::GIT -> fetcher -> systemd 
> > -> firewall -> anon-modules
> >     
> >     instead of:
> >         build::GIT -> VersionProcess -> systemd -> firewall -> Module/hooks 
> > -> anon-modules-> fetcher

The ordering is changed to firewall -> anon-modules -> modules/hooks -> 
VersionProcess -> builod::GIT -> VersionProcess -> systemd -> fetcher


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47892/#review134994
-----------------------------------------------------------


On June 12, 2016, 6:51 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47892/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-5452
>     https://issues.apache.org/jira/browse/MESOS-5452
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Re-ordered initialization for Agent `Anonymous` modules.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp fddb05c2d2756f823a4fa393373a9ebc0f14895c 
> 
> Diff: https://reviews.apache.org/r/47892/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo ./build/bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to