> On May 26, 2016, 11:52 a.m., Kapil Arya wrote: > > src/slave/main.cpp, lines 309-323 > > <https://reviews.apache.org/r/47892/diff/1/?file=1395393#file1395393line309> > > > > I am wondering if we should move it right next to the > > `ModuleManager::load()` call above. Is there a reason for not doing so? > > Avinash sridharan wrote: > We wanted to initialize the `Anonymous` module only after the Firewall is > initialized. Reason being that the module might also expoe endpoints that > need to be fiewalled ?
Okay, that a reasonable dependency. Can you please document it in the comments around the code? In any case, can we initialize firewall *before* initializing ModuleManager? That way, we can keep ModuleManager/AnonModules close together. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47892/#review134994 ----------------------------------------------------------- On May 26, 2016, 10:38 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47892/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:38 a.m.) > > > Review request for mesos, Jie Yu and Kapil Arya. > > > Bugs: MESOS-5452 > https://issues.apache.org/jira/browse/MESOS-5452 > > > Repository: mesos > > > Description > ------- > > Re-ordered initialization for Agent `Anonymous` modules. > > We are initializing the Anonymous modules right after the `Firewall` since > Anonymous modules might have endpoints on which firewall rules might need to > be enforced. > > > Diffs > ----- > > src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb > > Diff: https://reviews.apache.org/r/47892/diff/ > > > Testing > ------- > > make check > sudo ./build/bin/mesos-tests.sh > > > Thanks, > > Avinash sridharan > >
