----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47892/#review134994 -----------------------------------------------------------
src/slave/main.cpp (lines 239 - 288) <https://reviews.apache.org/r/47892/#comment199982> While we are discussing/fixing the ordering issues, can we reach a consensus on this particular ordering as well? As in, why do we have the following order: modules/hooks -> VersionProcess -> build::GIT -> fetcher -> systemd -> firewall -> anon-modules instead of: build::GIT -> VersionProcess -> systemd -> firewall -> Module/hooks -> anon-modules-> fetcher src/slave/main.cpp (line 270) <https://reviews.apache.org/r/47892/#comment199983> It's not yours but could you also move `fetcher` close to `containerizer` initialization? src/slave/main.cpp (lines 309 - 323) <https://reviews.apache.org/r/47892/#comment199981> I am wondering if we should move it right next to the `ModuleManager::load()` call above. Is there a reason for not doing so? - Kapil Arya On May 26, 2016, 10:38 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47892/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:38 a.m.) > > > Review request for mesos, Jie Yu and Kapil Arya. > > > Bugs: MESOS-5452 > https://issues.apache.org/jira/browse/MESOS-5452 > > > Repository: mesos > > > Description > ------- > > Re-ordered initialization for Agent `Anonymous` modules. > > We are initializing the Anonymous modules right after the `Firewall` since > Anonymous modules might have endpoints on which firewall rules might need to > be enforced. > > > Diffs > ----- > > src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb > > Diff: https://reviews.apache.org/r/47892/diff/ > > > Testing > ------- > > make check > sudo ./build/bin/mesos-tests.sh > > > Thanks, > > Avinash sridharan > >
