----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/#review138403 -----------------------------------------------------------
src/master/http.cpp (line 689) <https://reviews.apache.org/r/48879/#comment203567> I saw we do this check in scheduler::Call ``` if (request.headers.contains("Mesos-Stream-Id")) { return BadRequest( "Subscribe calls should not include the 'Mesos-Stream-Id' header"); } ``` Do we need do it here as well? src/master/http.cpp (line 696) <https://reviews.apache.org/r/48879/#comment203568> Do we need ``` // Generate a stream ID and return it in the response. UUID streamId = UUID::random(); ok.headers["Mesos-Stream-Id"] = streamId.toString(); ``` here? - haosdent huang On June 17, 2016, 8:52 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48879/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 8:52 p.m.) > > > Review request for mesos, Vinod Kone and Zhitao Li. > > > Bugs: MESOS-5609 > https://issues.apache.org/jira/browse/MESOS-5609 > > > Repository: mesos > > > Description > ------- > > This change sets the initial scaffolding in place allowing > a client to subscribe to events via the '/api/vX' endpoint. > Currently, only two events are supported i.e. `TASK_ADDED`/ > `TASK_UPDATED`. > > > Diffs > ----- > > src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d > src/master/master.hpp 0db18ad5fc5ba6f762c3ac0c2bc14c73fb243738 > src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df > > Diff: https://reviews.apache.org/r/48879/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
