> On June 18, 2016, 1:47 p.m., haosdent huang wrote: > > src/master/http.cpp, line 689 > > <https://reviews.apache.org/r/48879/diff/2/?file=1423145#file1423145line689> > > > > I saw we do this check in scheduler::Call > > ``` > > if (request.headers.contains("Mesos-Stream-Id")) { > > return BadRequest( > > "Subscribe calls should not include the 'Mesos-Stream-Id' > > header"); > > } > > ``` > > Do we need do it here as well?
See Zhitao's comment on why we don't need the stream ID here. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/#review138403 ----------------------------------------------------------- On June 17, 2016, 8:52 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48879/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 8:52 p.m.) > > > Review request for mesos, Vinod Kone and Zhitao Li. > > > Bugs: MESOS-5609 > https://issues.apache.org/jira/browse/MESOS-5609 > > > Repository: mesos > > > Description > ------- > > This change sets the initial scaffolding in place allowing > a client to subscribe to events via the '/api/vX' endpoint. > Currently, only two events are supported i.e. `TASK_ADDED`/ > `TASK_UPDATED`. > > > Diffs > ----- > > src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d > src/master/master.hpp 0db18ad5fc5ba6f762c3ac0c2bc14c73fb243738 > src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df > > Diff: https://reviews.apache.org/r/48879/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
