> On June 18, 2016, 1:47 p.m., haosdent huang wrote: > > src/master/http.cpp, line 696 > > <https://reviews.apache.org/r/48879/diff/2/?file=1423145#file1423145line696> > > > > Do we need > > ``` > > // Generate a stream ID and return it in the response. > > UUID streamId = UUID::random(); > > ok.headers["Mesos-Stream-Id"] = streamId.toString(); > > ``` > > here?
Right now, stream id is only explicitly defined in scheduler API, because it is expected that an active scheduler would send messages to Mesos master through a different channel to be processed for the stream. Mesos does not allocate an ID for clients registered through operator API yet, so I guess this part can live without a stream id. A more interesting but off-topic discussion would be whether executor API should use stream id in the same fashion of scheduler API: it is also well expected that an executor is allowed to send message and status update to scheduler through Mesos agent/master. While the mechanism is same with Mesos master, this part does not require a stream id. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/#review138403 ----------------------------------------------------------- On June 17, 2016, 8:52 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48879/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 8:52 p.m.) > > > Review request for mesos, Vinod Kone and Zhitao Li. > > > Bugs: MESOS-5609 > https://issues.apache.org/jira/browse/MESOS-5609 > > > Repository: mesos > > > Description > ------- > > This change sets the initial scaffolding in place allowing > a client to subscribe to events via the '/api/vX' endpoint. > Currently, only two events are supported i.e. `TASK_ADDED`/ > `TASK_UPDATED`. > > > Diffs > ----- > > src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d > src/master/master.hpp 0db18ad5fc5ba6f762c3ac0c2bc14c73fb243738 > src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df > > Diff: https://reviews.apache.org/r/48879/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
