----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/#review138486 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (lines 1217 - 1218) <https://reviews.apache.org/r/48919/#comment203668> In r/48918 you removed logging of the failed future, so now those failures are not captured in the log. I would strongly suggest to restore logging here. My preference would be `VLOG(3)`. 3rdparty/libprocess/src/process.cpp (line 1218) <https://reviews.apache.org/r/48919/#comment203671> In case future is not failed, you create a response with an empty body, but with some headers ("Content-Length", "Content-Type") set. I believe this is not what you want. How about: ``` Response response = future.isFailed() ? ServiceUnavailable(future.failure() : ServiceUnavailable(); socket_manager->send(response, request, socket); ``` 3rdparty/libprocess/src/process.cpp (lines 1220 - 1221) <https://reviews.apache.org/r/48919/#comment203672> We tend to insert a blank line in this case : ). - Alexander Rukletsov On June 19, 2016, 9:02 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48919/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 9:02 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, > Alexander Rojas, Benjamin Mahler, Greg Mann, and Kapil Arya. > > > Bugs: MESOS-5637 > https://issues.apache.org/jira/browse/MESOS-5637 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 703f673a98102958c5e2b0c1833efad2ddc53ef8 > > Diff: https://reviews.apache.org/r/48919/diff/ > > > Testing > ------- > > make check & functional testing. > > > Thanks, > > Till Toenshoff > >
