----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/#review138544 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (line 1218) <https://reviews.apache.org/r/48919/#comment203740> I don't think returning the contents of `future.failure()` as the body is a good idea. The failure messages usually contain details about the failures that are in general useful to debug, or configuration details that may not be useful to someone doing an HTTP request at best and just plain dangerous at worst (you may be spill configuration details). - Alexander Rojas On June 20, 2016, 7:50 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48919/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 7:50 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, > Alexander Rojas, Benjamin Mahler, Greg Mann, and Kapil Arya. > > > Bugs: MESOS-5637 > https://issues.apache.org/jira/browse/MESOS-5637 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 703f673a98102958c5e2b0c1833efad2ddc53ef8 > > Diff: https://reviews.apache.org/r/48919/diff/ > > > Testing > ------- > > make check (OSX and some Linux distros) > > > Thanks, > > Till Toenshoff > >
