> On June 19, 2016, 10:26 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, line 1218 > > <https://reviews.apache.org/r/48919/diff/1/?file=1423492#file1423492line1218> > > > > In case future is not failed, you create a response with an empty body, > > but with some headers ("Content-Length", "Content-Type") set. I believe > > this is not what you want. How about: > > ``` > > Response response = future.isFailed() ? > > ServiceUnavailable(future.failure() : > > ServiceUnavailable(); > > > > socket_manager->send(response, request, socket); > > ```
Good catch - indeed. ty! > On June 19, 2016, 10:26 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1217-1218 > > <https://reviews.apache.org/r/48919/diff/1/?file=1423492#file1423492line1217> > > > > In r/48918 you removed logging of the failed future, so now those > > failures are not captured in the log. I would strongly suggest to restore > > logging here. My preference would be `VLOG(3)`. I would like to go with VLOG(1) for now as that is how libprocess' own authorization / authentication already does it - so it is consistent with that. Sounds good? - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/#review138486 ----------------------------------------------------------- On June 19, 2016, 9:02 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48919/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 9:02 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, > Alexander Rojas, Benjamin Mahler, Greg Mann, and Kapil Arya. > > > Bugs: MESOS-5637 > https://issues.apache.org/jira/browse/MESOS-5637 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 703f673a98102958c5e2b0c1833efad2ddc53ef8 > > Diff: https://reviews.apache.org/r/48919/diff/ > > > Testing > ------- > > make check & functional testing. > > > Thanks, > > Till Toenshoff > >
