----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49130/#review139212 -----------------------------------------------------------
Could you refactor `_tasks()`, `stateSummary()` to use this helper as well? src/master/http.cpp (lines 1493 - 1496) <https://reviews.apache.org/r/49130/#comment204347> I'm not sure about indentation here, maybe align arguments at left paren? src/master/http.cpp (line 1660) <https://reviews.apache.org/r/49130/#comment204352> I guess we can still `make_tuple` here and unpack them using `tie` in `.then{...}`? - Jay Guo On June 23, 2016, 3:53 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49130/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 3:53 a.m.) > > > Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > Helper function for approver creation in master::http. > > > Diffs > ----- > > src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e > src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 > > Diff: https://reviews.apache.org/r/49130/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >
