> On June 23, 2016, 3:11 a.m., Jay Guo wrote:
> > Also we need to strip whitespaces in `token`, since `strtoul` ignores
> > leading whitespaces without generating any errors. For example, this test
> > fails with current implementation:
> > `EXPECT_ERROR(net::MAC::parse(" 2:34:56:78:9a:bc"));`
>
> Avinash sridharan wrote:
> I missed that :(. Would it better to use sscanf instead ?
Agreed.
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49122/#review139204
-----------------------------------------------------------
On June 22, 2016, 11:56 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49122/
> -----------------------------------------------------------
>
> (Updated June 22, 2016, 11:56 p.m.)
>
>
> Review request for mesos, Avinash sridharan and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a MAC parse function to stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/mac.hpp
> 1aaafe1380c5300225c2ac9276e87962bd5a0d88
> 3rdparty/stout/tests/mac_tests.cpp f905d4528040ce97d80010b2ba3f13870dca0c7c
>
> Diff: https://reviews.apache.org/r/49122/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
