> On June 23, 2016, 2:45 a.m., Jay Guo wrote: > > 3rdparty/stout/include/stout/mac.hpp, lines 95-97 > > <https://reviews.apache.org/r/49122/diff/2/?file=1428152#file1428152line95> > > > > I wonder if this is necessary given two digit hex ( `if > > (tokens[i].size() != 2)` ...) > > Jie Yu wrote: > yep, you're right! used a CHECK instead.
In fact, i realized that `-1` is a valid hex as well. that'll break the CHECK. so, i changed my impl. to check each digit explicitly. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/#review139202 ----------------------------------------------------------- On June 22, 2016, 11:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49122/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 11:56 p.m.) > > > Review request for mesos, Avinash sridharan and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > Added a MAC parse function to stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/mac.hpp > 1aaafe1380c5300225c2ac9276e87962bd5a0d88 > 3rdparty/stout/tests/mac_tests.cpp f905d4528040ce97d80010b2ba3f13870dca0c7c > > Diff: https://reviews.apache.org/r/49122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
