----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49122/#review139178 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/mac.hpp (line 84) <https://reviews.apache.org/r/49122/#comment204603> Good catch by Jay. We should have a tmp string to do a `strings::trim` here. - Gilbert Song On June 22, 2016, 4:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49122/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 4:56 p.m.) > > > Review request for mesos, Avinash sridharan and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > Added a MAC parse function to stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/mac.hpp > 1aaafe1380c5300225c2ac9276e87962bd5a0d88 > 3rdparty/stout/tests/mac_tests.cpp f905d4528040ce97d80010b2ba3f13870dca0c7c > > Diff: https://reviews.apache.org/r/49122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
