----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139465 -----------------------------------------------------------
include/mesos/appc/spec.proto (line 44) <https://reviews.apache.org/r/49207/#comment204696> s/would/Would Can you please rephrase this part? Do not quite follow what you mean as I did not see any thing related to volume, flags, pre/post handlers at https://github.com/appc/spec/blob/master/spec/aci.md#image-manifest-schema include/mesos/appc/spec.proto (line 45) <https://reviews.apache.org/r/49207/#comment204695> Add a period to the end include/mesos/appc/spec.proto (line 50) <https://reviews.apache.org/r/49207/#comment204698> What about `optional Environment environment = 3;` - Guangya Liu On 六月 25, 2016, 4:08 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49207/ > ----------------------------------------------------------- > > (Updated 六月 25, 2016, 4:08 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added proto message definitions to support appc runtime. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto f17a3a4f167eb203709d7ebac3ade220ac8641ea > > Diff: https://reviews.apache.org/r/49207/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
