> On June 28, 2016, 1:11 p.m., Guangya Liu wrote: > > include/mesos/appc/spec.proto, lines 44-46 > > <https://reviews.apache.org/r/49207/diff/4/?file=1431426#file1431426line44> > > > > I saw that you dropped previous comments, but it would be great if you > > can show some comments to explain when you want to drop some comments ;-) > > > > I would suggest that you add a link as following here as comment so > > that people will clear where does those field from. > > > > https://github.com/appc/spec/blob/master/spec/aci.md#image-manifest-schema > > > > Other comments are: > > 1) Please always add a period for all of your comments. > > 2) Always start with a upper case charactor for a sentense, for your > > case, it would be /*TODO(srbrahma): Would xxxxx*/ , but I think the > > comments here needs to be updated.
@Gyliu, I dropped the comments because it does not make sense. I did add a comment to explain that. Since the whole proto conforms to Appc spec I think calling out missing fields is not necessary. - Srinivas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139774 ----------------------------------------------------------- On June 28, 2016, 9:45 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49207/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 9:45 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added proto message definitions to support appc runtime. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto f17a3a4f167eb203709d7ebac3ade220ac8641ea > > Diff: https://reviews.apache.org/r/49207/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
