> On June 26, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/appc/spec.proto, line 50 > > <https://reviews.apache.org/r/49207/diff/3/?file=1430043#file1430043line50> > > > > What about `optional Environment environment = 3;`
We thought of duplicating "Label" as another message "Environment". For simplicity we keep it like this for now. - Srinivas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139465 ----------------------------------------------------------- On June 28, 2016, 9:45 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49207/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 9:45 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added proto message definitions to support appc runtime. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto f17a3a4f167eb203709d7ebac3ade220ac8641ea > > Diff: https://reviews.apache.org/r/49207/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
