> On 六月 27, 2016, 6:14 p.m., Gilbert Song wrote:
> > Srini, I guess you may want to add another patch before this one to
> > implement the runtime isolator then plug it in using this patch. And you
> > may need to rebase and figure out why your patches failed on review bot.
The build failure is caused by `{"appc/runtime",
&AppcRuntimeIsolatorProcess::create},`, here should be
"App`C`RuntimeIsolatorProcess".
> On 六月 27, 2016, 6:14 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 311
> > <https://reviews.apache.org/r/49232/diff/1/?file=1430205#file1430205line311>
> >
> > Move above docker runtime.
Gilbert, just a question, do you think we need keep alphina order here?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review139621
-----------------------------------------------------------
On 六月 25, 2016, 10:53 p.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> -----------------------------------------------------------
>
> (Updated 六月 25, 2016, 10:53 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-4778
> https://issues.apache.org/jira/browse/MESOS-4778
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added appcManifest to ImageInfo and ProvisionInfo.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp
> d984efd4742ec084d66538c48a36ea768832324d
> src/slave/containerizer/mesos/provisioner/appc/store.cpp
> aaa0efe63e587b9e604082b52a3cb8c11545fbb9
> src/slave/containerizer/mesos/provisioner/provisioner.hpp
> 48a05059969e068a0ee0d38b61be9e7104e3188d
> src/slave/containerizer/mesos/provisioner/provisioner.cpp
> 249acad49122d988e44744384bcf840b941c0997
> src/slave/containerizer/mesos/provisioner/store.hpp
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746
>
> Diff: https://reviews.apache.org/r/49232/diff/
>
>
> Testing
> -------
>
> Make Check.
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
