> On June 27, 2016, 6:14 p.m., Gilbert Song wrote:
> > Srini, I guess you may want to add another patch before this one to
> > implement the runtime isolator then plug it in using this patch. And you
> > may need to rebase and figure out why your patches failed on review bot.
>
> Guangya Liu wrote:
> The build failure is caused by `{"appc/runtime",
> &AppcRuntimeIsolatorProcess::create},`, here should be
> "App`C`RuntimeIsolatorProcess".
>
> Gilbert Song wrote:
> Thanks Guangya. @Srini, please make sure your patches are compilable and
> tested before pushing to the review board.
@gilbert I think we can test runtime without having implementation of the
isolator.
patch to add tests, to test appc tar ball
patch to add implementation for exec, workingDirectory and environment
patch to add tests to see if exec, workingDirectory and environment are
properly updated at runtime.
- Srinivas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review139621
-----------------------------------------------------------
On June 28, 2016, 6:39 a.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 6:39 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-4778
> https://issues.apache.org/jira/browse/MESOS-4778
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added appcManifest to ImageInfo and ProvisionInfo.
>
>
> Diffs
> -----
>
> include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4
> include/mesos/slave/isolator.proto f17a3a4f167eb203709d7ebac3ade220ac8641ea
> src/slave/containerizer/mesos/containerizer.cpp
> d984efd4742ec084d66538c48a36ea768832324d
> src/slave/containerizer/mesos/provisioner/appc/store.cpp
> aaa0efe63e587b9e604082b52a3cb8c11545fbb9
> src/slave/containerizer/mesos/provisioner/provisioner.hpp
> 48a05059969e068a0ee0d38b61be9e7104e3188d
> src/slave/containerizer/mesos/provisioner/provisioner.cpp
> 249acad49122d988e44744384bcf840b941c0997
> src/slave/containerizer/mesos/provisioner/store.hpp
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746
>
> Diff: https://reviews.apache.org/r/49232/diff/
>
>
> Testing
> -------
>
> Make Check.
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
