----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49095/#review139684 -----------------------------------------------------------
src/master/http.cpp (line 1188) <https://reviews.apache.org/r/49095/#comment204984> and executors? src/master/http.cpp (line 1235) <https://reviews.apache.org/r/49095/#comment204990> indent by 4 spaces. src/master/http.cpp (line 1257) <https://reviews.apache.org/r/49095/#comment204992> indent by 4 spaces. src/master/http.cpp (line 1274) <https://reviews.apache.org/r/49095/#comment204989> is this comment properly indented? src/tests/master_authorization_tests.cpp (line 1408) <https://reviews.apache.org/r/49095/#comment204993> /frameworks ? src/tests/master_authorization_tests.cpp (line 1413) <https://reviews.apache.org/r/49095/#comment204995> s/stateEndpoint/frameworksEndpoint/ also move this to where it is used. #1537. src/tests/master_authorization_tests.cpp (line 1414) <https://reviews.apache.org/r/49095/#comment204997> move this to where it is used. #1475. does this really need to be pulled into a variable? - Vinod Kone On June 24, 2016, noon, Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49095/ > ----------------------------------------------------------- > > (Updated June 24, 2016, noon) > > > Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. > > > Bugs: mesos-5704 > https://issues.apache.org/jira/browse/mesos-5704 > > > Repository: mesos > > > Description > ------- > > Even if ACLs were defined for the actions `VIEW_FRAMEWORKS`, > `VIEW_EXECUTORS` and `VIEW_TASKS`, the data these actions were > supposed to protect, could still leaked through the master's > `/frameworks` endpoint, since it didn't enable any authorization > mechanism. > > > Diffs > ----- > > src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e > src/tests/master_authorization_tests.cpp > 9ae6b9dc89538716d397ffd8826187e2bc6d7e8f > > Diff: https://reviews.apache.org/r/49095/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
