----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49095/#review139875 -----------------------------------------------------------
Fix it, then Ship it! i'll fix the raised issue while committing. src/master/http.cpp (lines 1207 - 1208) <https://reviews.apache.org/r/49095/#comment205221> move `Framework*` to the above line and indent accordingly. - Vinod Kone On June 28, 2016, 1:17 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49095/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 1:17 p.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. > > > Bugs: mesos-5704 > https://issues.apache.org/jira/browse/mesos-5704 > > > Repository: mesos > > > Description > ------- > > Even if ACLs were defined for the actions `VIEW_FRAMEWORKS`, > `VIEW_EXECUTORS` and `VIEW_TASKS`, the data these actions were > supposed to protect, could still leaked through the master's > `/frameworks` endpoint, since it didn't enable any authorization > mechanism. > > > Diffs > ----- > > src/master/http.cpp e089fe960779f39b3321f2ec81ab2acc17d53641 > src/tests/master_authorization_tests.cpp > 81804e0522fd6b26155732af08e33c4d0bb0a8fe > > Diff: https://reviews.apache.org/r/49095/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
