> On June 28, 2016, 1:01 a.m., Vinod Kone wrote: > > src/master/http.cpp, line 1295 > > <https://reviews.apache.org/r/49095/diff/1/?file=1427489#file1427489line1295> > > > > is this comment properly indented?
Sorry, my editor did that edition and I didn't notice it. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49095/#review139684 ----------------------------------------------------------- On June 24, 2016, 2 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49095/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 2 p.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. > > > Bugs: mesos-5704 > https://issues.apache.org/jira/browse/mesos-5704 > > > Repository: mesos > > > Description > ------- > > Even if ACLs were defined for the actions `VIEW_FRAMEWORKS`, > `VIEW_EXECUTORS` and `VIEW_TASKS`, the data these actions were > supposed to protect, could still leaked through the master's > `/frameworks` endpoint, since it didn't enable any authorization > mechanism. > > > Diffs > ----- > > src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e > src/tests/master_authorization_tests.cpp > 9ae6b9dc89538716d397ffd8826187e2bc6d7e8f > > Diff: https://reviews.apache.org/r/49095/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
