----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49281/#review139689 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/socket.hpp (line 272) <https://reviews.apache.org/r/49281/#comment205002> Rather than saying `the library`, can you make it more explicit and say `all implementations of this interface`? `These options should be optional` could also be reworded. How about `Consider making this configurable by the caller.` 3rdparty/libprocess/include/process/socket.hpp (line 273) <https://reviews.apache.org/r/49281/#comment205001> Can you reference a JIRA with this `TODO`? 3rdparty/libprocess/src/libevent_ssl_socket.cpp (lines 808 - 809) <https://reviews.apache.org/r/49281/#comment205003> Can we use a consistent comment in all places? - Joris Van Remoortere On June 27, 2016, 7:38 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49281/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 7:38 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-5723 > https://issues.apache.org/jira/browse/MESOS-5723 > > > Repository: mesos > > > Description > ------- > > All sockets made by libprocess are, by default, nonblocking and not > inherited by forks. This is the opposite of the Linux default and > should be modify-able by the user of libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 9b3abcfaf6cfb33290ccdb957801c0d029d78745 > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 3f80e863fdbb62d4cf7ce1b46c468a09f0694f56 > 3rdparty/libprocess/src/poll_socket.cpp > d14dd1ae210e112b917329803dfb09d98386b966 > > Diff: https://reviews.apache.org/r/49281/diff/ > > > Testing > ------- > > Comment change only. > > > Thanks, > > Joseph Wu > >
