-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49281/
-----------------------------------------------------------

(Updated June 27, 2016, 6:30 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Consolidated TODO comments.  Ended up tweaking a few associated comments.


Summary (updated)
-----------------

Added TODOs to make Socket CLOEXEC optional.


Bugs: MESOS-5723
    https://issues.apache.org/jira/browse/MESOS-5723


Repository: mesos


Description (updated)
-------

All sockets made by libprocess are, by default, nonblocking and not
inherited by forks.  This is the opposite of the Linux default.

Nonblocking is a requirement of libprocess, but "close-on-exec" is not.
The latter should be modify-able by the user of libprocess.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/socket.hpp 
9b3abcfaf6cfb33290ccdb957801c0d029d78745 

Diff: https://reviews.apache.org/r/49281/diff/


Testing
-------

Comment change only.


Thanks,

Joseph Wu

Reply via email to